cc: toolchain: Add x86_64 sysroot [CLARM-39] #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jungleraptor
left a comment
jungleraptor
left a comment
There was a problem hiding this comment.
Would also like a link to a test PR I can run so we can test these changes on mac.
Contributor
Author
|
@isaactorz Here is the test PR: https://github.com/swift-nav/orion/pull/5903 |
| fail(target_system_name + " is not a target tripplet") | ||
|
|
||
| cross_compile = host_system_name != target_system_name | ||
| use_bundled_libcpp = builtin_sysroot != None and not is_darwin |
Contributor
There was a problem hiding this comment.
Suggested change
| use_bundled_libcpp = builtin_sysroot != None and not is_darwin | |
| use_libstdcpp = builtin_sysroot != None and not is_darwin |
nit - the variable name doesn't match the logic. When this is true we should use libstdc++ not libc++
5 tasks
jungleraptor
added a commit
that referenced
this pull request
Jun 22, 2023
Fixes #92. We made it so that the condition that chooses between libstdc++ and libc++ always ends up selecting libstdc++. See PR for more details. The fix required a fairly non-trivial refactor of our toolchain configuration algorithm in cc_toolchain_config to support all the configurations we want.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds ability to use x86_64 sysroot with llvm toolchain. Usage:
bazel build //... --@rules_swiftnav//cc:enable_sysroot=trueRelated PR
swift-nav/swift-toolchains#19